linux-kernel - Re: [PATCH] tracing: Fix file mode of free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1369785877.15552.56.camel@gandalf.local.home>
Date:	Tue, 28 May 2013 20:04:37 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	David Sharp <dhsharp@...gle.com>
Cc:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>,
	Wang YanQing <udknight@...il.com>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: Fix file mode of free_buffer

On Tue, 2013-05-28 at 13:14 -0700, David Sharp wrote:
> On Tue, May 28, 2013 at 12:34 PM, Vaibhav Nagarnaik
> <vnagarnaik@...gle.com> wrote:
> > On Sun, May 26, 2013 at 1:52 AM, Wang YanQing <udknight@...il.com> wrote:
> >> Commit 4f271a2a60c748599b30bb4dafff30d770439b96
> >> (tracing: Add a proc file to stop tracing and free buffer)
> >> implement a method to free up ring buffer in kernel memory
> >> in the release code path of free_buffer's fd.
> >>
> >> Then we don't need read/write support for free_buffer,
> >> indeed we just have a dummy write fop, and don't implement read fop.
> >>
> >> So the 0200 is more reasonable file mode for free_buffer than
> >> the current file mode 0644.
> >>
> >> Signed-off-by: Wang YanQing <udknight@...il.com>
> >
> > Acked-by: Vaibhav Nagarnaik <vnagarnaik@...gle.com>
> 
> Acked-by: David Sharp <dhsharp@...gle.com>
> 
> >

Thanks guys,

As this isn't that big of a deal, I'm going to just queue this for 3.11.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/