lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 May 2013 15:35:28 -0500 From: Mark Langsdorf <mark.langsdorf@...xeda.com> To: Timur Tabi <timur@...i.org> CC: lkml <linux-kernel@...r.kernel.org>, Tejun Heo <tj@...nel.org>, "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org> Subject: Re: [PATCH] ata: increase retry count but shorten duration for Calxeda controller On 05/29/2013 03:12 PM, Timur Tabi wrote: > On Wed, May 29, 2013 at 10:51 AM, Mark Langsdorf > <mark.langsdorf@...xeda.com> wrote: >> >> { >> - const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context); >> + unsigned long timing[] = { 5, 100, 500}; > > > You didn't address my comments the last time you posted this. I'll > post them again: > > > Why are you dropping the 'const'? > > Assuming it works, this should be more efficient: > > static const unsigned long timing[] = {5, 100, 500}; I thought there was a compile issue, but I just rechecked and there wasn't. I'll fix for the next submission. Thanks for the review. --Mark Langsdorf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists