linux-kernel - RE: [PATCH v1 0/9] adding dual instance and usb-phy support for am335x platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 May 2013 03:46:20 +0000
From:	"B, Ravi" <ravibabu@...com>
To:	"Balbi, Felipe" <balbi@...com>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1 0/9] adding dual instance and usb-phy support for
 am335x platform

Felipe

> Subject: Re: [PATCH v1 0/9] adding dual instance and usb-phy support for am335x platform

> Hi,

>On Thu, May 23, 2013 at 11:31:19AM +0530, Ravi Babu wrote:
>> This patch set series
>>         - adds dual musb instances support for am335x platform
>>         - adds phy-dsps-usb driver based on TI's gs70 driver
>>         - adds DT bindings for am33xx usb-phy
>> 	- removed references to usb-nop-xceiv from musb

>as Sergei pointed out, this would break some DaVinci/DA8xx platforms, so I'm dropping from it from my queue.

As I understand, already all musb glue platform drivers(dsps/davinci/da8xx) are changed to new usb_get_phy() API set.  
Currently the mainline code snippet as shown.

dsps/davinci/da8xx/xxx_musb_init() {
...
        usb_nop_xceiv_register() 
..
        musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2);
        if (IS_ERR_OR_NULL(musb->xceiv)) {
                ret = -EPROBE_DEFER;
                goto fail;
        }
..
}
Because of this all glue xxx_musb_init() will fail to get the phy without the phy-bindings for each controller. 
Without this patch series am335x musb will fail to get usb_phy(). Similarly phy support to be added for all davinci/da8xx
platform also. The usb_nop_xciev_xx() is dummy unused API here and hence removed from all glue in this patch series.

1) dsps platforms (am335x/dm81xx) series uses TI gs70 based phy 
	This patch adds support for ths dsps phy driver at drivers/usb/phy/usb-dsps-phy.c 
2) omapl13x/da8xx series of soc uses different phy
	Separate phy driver need to be added at drivers/usb/phy/usb-da8xx-phy.c
3) similarly all davinci series of soc uses separate TI-phy 
	Separate phy driver need to added at drivers/usb/phy/usb-davinci-phy.c

The bindings of the respective usb-phy and controller need to done in DT or non-DT way.  
I can add usb-phy support for davinci/da8xx platform in similar way.

---
Ravi B
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/