lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 May 2013 10:20:45 +0900 From: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@...esas.com> To: balbi@...com Cc: Alexey Khoroshilov <khoroshilov@...ras.ru>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org Subject: Re: [PATCH] usb: gadget: r8a66597-udc: do not unlock unheld spinlock in r8a66597_sudmac_irq() Hi, (2013/05/30 8:58), Felipe Balbi wrote: > HI, > > On Thu, May 30, 2013 at 12:51:37AM +0400, Alexey Khoroshilov wrote: >> r8a66597_irq() processes sudmac part (r8a66597_sudmac_irq()) before locking r8a66597->lock. >> But transfer_complete(), that is called inside (r8a66597_sudmac_irq()->sudmac_finish()->transfer_complete()), >> expects r8a66597->lock is locked. As a result unheld spinlock can be unlocked. >> >> The patch just moves locking before calling r8a66597_sudmac_irq(). >> >> Found by Linux Driver Verification project (linuxtesting.org). >> >> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru> > > should this go to stable ? Looks like this bug has been there since > 2.6.32. > Because non SMP CPUs have sudmac for now, this may not go to stable, I think. Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists