linux-kernel - Re: [PATCH] PM: Add pm_ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 May 2013 12:56:45 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Pavel Machek <pavel@....cz>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Jingoo Han <jg1.han@...sung.com>, linux-pm@...r.kernel.org,
	'Len Brown' <len.brown@...el.com>,
	'Andrew Morton' <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH] PM: Add pm_ops_ptr() macro

On Fri, May 03, 2013 at 11:23:11AM +0200, Pavel Machek wrote:
> Hi!
> 
> > > Add pm_ops_ptr() macro that allows the .pm entry in the driver structures
> > > to be assigned without having an #define xxx NULL for the case that PM is
> > > not enabled.
> > > 
> > > Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> > 
> > I've queued this up as v3.11 material.
> 
> > > --- a/drivers/i2c/busses/i2c-s3c2410.c
> > > +++ b/drivers/i2c/busses/i2c-s3c2410.c
> > > @@ -1218,7 +1218,6 @@ static int s3c24xx_i2c_resume(struct device *dev)
> > >  }
> > >  #endif
> > >  
> > > -#ifdef CONFIG_PM
> > >  static const struct dev_pm_ops s3c24xx_i2c_dev_pm_ops = {
> > >  #ifdef CONFIG_PM_SLEEP
> > >  	.suspend_noirq = s3c24xx_i2c_suspend_noirq,
> > > @@ -1226,11 +1225,6 @@ static const struct dev_pm_ops s3c24xx_i2c_dev_pm_ops = {
> > >  #endif
> > >  };
> > >  
> > > -#define S3C24XX_DEV_PM_OPS (&s3c24xx_i2c_dev_pm_ops)
> > > -#else
> > > -#define S3C24XX_DEV_PM_OPS NULL
> > > -#endif
> > > -
> > >  /* device driver for platform bus bits */
> 
> Will not this enlarge .data by sizeof(struct dev_pm_ops)?

Same question here. Is it the preferred way now to use this new macro
although having the cost of having an empty dev_pm_ops?


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)