| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHp75VfHN_8s7gx=a0TLkkPgeZx=cvcXwbfFQPYPG0XDEW-zJA@mail.gmail.com> Date: Thu, 30 May 2013 14:55:12 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Nikolay Balandin <nbalandin@....rtsoft.ru> Cc: Nikolay Balandin <n.a.balandin@...il.com>, Eric Piel <eric.piel@...mplin-utc.net>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v1 1/1] drivers/misc: lis3lv02d: convert to use devm_regulator_bulk_get On Thu, May 30, 2013 at 10:03 AM, Nikolay Balandin <nbalandin@....rtsoft.ru> wrote: > Yes, this accelerometer is present on the Kontron SMARC evaluation > carrier. > http://emea.kontron.com/products/computeronmodules/smarc/smarc+evaluation+carrier.html Good. I think you may do following things: - update lis3lv02d.c to use devm_* functions - and then update i2c driver to use devm_* Are you going to support that platform via DeviceTree model? > On Wed, May 29, 2013 at 2:45 PM, Nikolay Balandin > <n.a.balandin@...il.com> wrote: > Use devm_regulator_bulk_get to make cleanup paths simpler > > Do you plan to use this driver somewhere outside of Nokia n900 device? > If so, there is more than this clean up to do. > > Otherwise I don't think we have to touch that driver at all. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists