linux-kernel - Re: [PATCHv3 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaf81BBGKaDwjMW=AWe+nrstbyLoYyTHFqfXqRnOmmNVA@mail.gmail.com>
Date:	Thu, 30 May 2013 20:02:08 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Rohit Vaswani <rvaswani@...eaurora.org>
Cc:	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>,
	Russell King <linux@....linux.org.uk>,
	David Brown <davidb@...eaurora.org>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCHv3 3/3] gpio: msm: Add device tree and irqdomain support
 for gpio-msm-v2

On Fri, May 24, 2013 at 8:32 PM, Rohit Vaswani <rvaswani@...eaurora.org> wrote:

> This cleans up the gpio-msm-v2 driver of all the global define usage.
> The number of gpios are now defined in the device tree. This enables
> adding irqdomain support as well.
>
> Signed-off-by: Rohit Vaswani <rvaswani@...eaurora.org>

Good clean-up so:
Acked-by: Linus Walleij <linus.walleij@...aro.org>

But here is an unrelated hint for later refactoring:

> +       msmgpio: gpio@...000 {
> +               compatible = "qcom,msm-gpio";
> +               reg = <0x00800000 0x1000>;
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +               ngpio = <173>;
> +               interrupts = <0 32 0x4>;

If you switch the dts[i] files to use the C preprocessor include syntax
you can change all interrupts to look like so:

#include <dt-bindings/interrupt-controller/irq.h>

interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>;

Which is helpful.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/