linux-kernel - RE: [PATCH 5/7] dwc2: remove redundant D0 power state set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 30 May 2013 18:18:22 +0000
From:	Paul Zimmerman <Paul.Zimmerman@...opsys.com>
To:	Yijing Wang <wangyijing@...wei.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Hanjun Guo <guohanjun@...wei.com>, Jiang Liu <liuj97@...il.com>
Subject: RE: [PATCH 5/7] dwc2: remove redundant D0 power state set

> From: Yijing Wang [mailto:wangyijing@...wei.com]
> Sent: Thursday, May 30, 2013 3:24 AM
> 
> Pci_enable_device() will set device power state to D0,
> so it's no need to do it again in dwc2_driver_probe().
> 
> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
> ---
>  drivers/staging/dwc2/pci.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c
> index 69c65eb..6a196c2 100644
> --- a/drivers/staging/dwc2/pci.c
> +++ b/drivers/staging/dwc2/pci.c
> @@ -131,8 +131,6 @@ static int dwc2_driver_probe(struct pci_dev *dev,
>  	if (!hsotg)
>  		return -ENOMEM;
> 
> -	pci_set_power_state(dev, PCI_D0);
> -
>  	hsotg->dev = &dev->dev;
>  	hsotg->regs = devm_request_and_ioremap(&dev->dev, &dev->resource[0]);
>  	if (!hsotg->regs)
> --
> 1.7.1

Acked-by: Paul Zimmerman <paulz@...opsys.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/