linux-kernel - Re: [PATCH] gpio: sx150x: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZFj4LXB6NDFerVTNYJvdt04VvD0cYiz=1dL+LSXLWg=A@mail.gmail.com>
Date:	Thu, 30 May 2013 20:47:21 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Nikolay Balandin <n.a.balandin@...il.com>
Cc:	Grant Likely <grant.likely@...aro.org>,
	Nikolay Balandin <nbalandin@....rtsoft.ru>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: sx150x: use devm_kzalloc()

On Fri, May 24, 2013 at 1:21 PM, Nikolay Balandin
<n.a.balandin@...il.com> wrote:

> Use devm_kzalloc() to make cleanup paths simpler.
>
> Signed-off-by: Nikolay Balandin <nbalandin@....rtsoft.ru>

You forgot to remove the kfree(chip); in sx150x_remove().

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/