linux-kernel - Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130530052136.GF2367@dell.arpanet.local>
Date:	Thu, 30 May 2013 07:21:36 +0200
From:	Jon Arne Jørgensen <jonarne@...arne.no>
To:	Andy Walls <awalls@...metrocast.net>
Cc:	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Jon Arne Jørgensen <jonarne@...arne.no>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	hans.verkuil@...co.com, prabhakar.csengg@...il.com,
	g.liakhovetski@....de, ezequiel.garcia@...e-electrons.com,
	timo.teras@....fi
Subject: Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

On Wed, May 29, 2013 at 10:19:49PM -0400, Andy Walls wrote:
> Mauro Carvalho Chehab <mchehab@...hat.com> wrote:
> 
> >Em Wed, 29 May 2013 22:41:16 +0200
> >Jon Arne Jørgensen <jonarne@...arne.no> escreveu:
> >
> >> Change all default values in the initial setup table to match the
> >table
> >> in the datasheet.
> >
> >This is not a good idea, as it can produce undesired side effects
> >on the existing drivers that depend on it, and can't be easily
> >tested.
> >
> >Please, don't change the current "default". It is, of course, OK
> >to change them if needed via the information provided inside the
> >platform data.
> >
> >Regards,
> >Mauro
> >> 
> >> Signed-off-by: Jon Arne Jørgensen <jonarne@...arne.no>
> >> ---
> >>  drivers/media/i2c/saa7115.c | 12 ++++++------
> >>  1 file changed, 6 insertions(+), 6 deletions(-)
> >> 
> >> diff --git a/drivers/media/i2c/saa7115.c
> >b/drivers/media/i2c/saa7115.c
> >> index d6f589a..4403679 100644
> >> --- a/drivers/media/i2c/saa7115.c
> >> +++ b/drivers/media/i2c/saa7115.c
> >> @@ -223,12 +223,12 @@ static const unsigned char saa7111_init[] = {
> >>  static const unsigned char saa7113_init[] = {
> >>  	R_01_INC_DELAY, 0x08,
> >>  	R_02_INPUT_CNTL_1, 0xc2,
> >> -	R_03_INPUT_CNTL_2, 0x30,
> >> +	R_03_INPUT_CNTL_2, 0x33,
> >>  	R_04_INPUT_CNTL_3, 0x00,
> >>  	R_05_INPUT_CNTL_4, 0x00,
> >> -	R_06_H_SYNC_START, 0x89,
> >> +	R_06_H_SYNC_START, 0xe9,
> >>  	R_07_H_SYNC_STOP, 0x0d,
> >> -	R_08_SYNC_CNTL, 0x88,
> >> +	R_08_SYNC_CNTL, 0x98,
> >>  	R_09_LUMA_CNTL, 0x01,
> >>  	R_0A_LUMA_BRIGHT_CNTL, 0x80,
> >>  	R_0B_LUMA_CONTRAST_CNTL, 0x47,
> >> @@ -236,11 +236,11 @@ static const unsigned char saa7113_init[] = {
> >>  	R_0D_CHROMA_HUE_CNTL, 0x00,
> >>  	R_0E_CHROMA_CNTL_1, 0x01,
> >>  	R_0F_CHROMA_GAIN_CNTL, 0x2a,
> >> -	R_10_CHROMA_CNTL_2, 0x08,
> >> +	R_10_CHROMA_CNTL_2, 0x00,
> >>  	R_11_MODE_DELAY_CNTL, 0x0c,
> >> -	R_12_RT_SIGNAL_CNTL, 0x07,
> >> +	R_12_RT_SIGNAL_CNTL, 0x01,
> >>  	R_13_RT_X_PORT_OUT_CNTL, 0x00,
> >> -	R_14_ANAL_ADC_COMPAT_CNTL, 0x00,
> >> +	R_14_ANAL_ADC_COMPAT_CNTL, 0x00,	/* RESERVED */
> >>  	R_15_VGATE_START_FID_CHG, 0x00,
> >>  	R_16_VGATE_STOP, 0x00,
> >>  	R_17_MISC_VGATE_CONF_AND_MSB, 0x00,
> >
> >
> >-- 
> >
> >Cheers,
> >Mauro
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-media"
> >in
> >the body of a message to majordomo@...r.kernel.org
> >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> I was going to make a comment along the same line as Mauro.  
> Please leave the driver defaults alone.  It is almost impossible to regression test all the different devices with a SAA7113 chip, to ensure the change doesn't cause someone's device to not work properly.
>

You guys are totally right.

What if I clone the original saa7113_init table into a new one, and make
the driver use the new one if the calling driver sets platform_data.

Something like this?

        switch (state->ident) {
        case V4L2_IDENT_SAA7111:
        case V4L2_IDENT_SAA7111A:
                saa711x_writeregs(sd, saa7111_init);
                break;
        case V4L2_IDENT_GM7113C:
        case V4L2_IDENT_SAA7113:
-		saa711x_writeregs(sd, saa7113_init);
+		if (client->dev.platform_data)
+			saa711x_writeregs(sd, saa7113_new_init);
+		else
+			saa711x_writeregs(sd, saa7113_init);

                break;
        default:
                state->crystal_freq = SAA7115_FREQ_32_11_MHZ;
                saa711x_writeregs(sd, saa7115_init_auto_input);
        }
        if (state->ident > V4L2_IDENT_SAA7111A)
                saa711x_writeregs(sd, saa7115_init_misc);

        if (client->dev.platform_data) {
                struct saa7115_platform_data *data = client->dev.platform_data;
                saa7115_load_platform_data(state, data);
        }

It's not strictly necessary, but it feels a lot cleaner?
Would you accept this into the kernel, or would it just increase
maintenance?

Best regards
Jon Arne Jørgensen

> Regards,
> Andy
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/