linux-kernel - Re: [PATCH 04/16] perf, persistent: Print error code on failure when adding events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130531091034.GE14076@nazgul.tnic>
Date:	Fri, 31 May 2013 11:10:34 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Robert Richter <rric@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org,
	Robert Richter <robert.richter@...xeda.com>
Subject: Re: [PATCH 04/16] perf, persistent: Print error code on failure when
 adding events

On Fri, May 31, 2013 at 10:47:24AM +0200, Robert Richter wrote:
> From: Robert Richter <robert.richter@...xeda.com>
> 
> Improve error reporting.
> 
> Signed-off-by: Robert Richter <robert.richter@...xeda.com>
> ---
>  kernel/events/persistent.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/events/persistent.c b/kernel/events/persistent.c
> index 1e6c03a..6612eb77 100644
> --- a/kernel/events/persistent.c
> +++ b/kernel/events/persistent.c
> @@ -123,15 +123,15 @@ int perf_add_persistent_event(struct perf_event_attr *attr, unsigned nr_pages)
>  
>  	for_each_possible_cpu(i) {
>  		event = add_persistent_event_on_cpu(i, attr, nr_pages);
> -		if (IS_ERR(event)) {
> -			pr_err("%s: Error adding persistent event on cpu %d\n",
> -				__func__, i);
> +		if (IS_ERR(event))
>  			goto unwind;
> -		}
>  	}
>  	return 0;
>  
>  unwind:
> +	pr_err("%s: Error adding persistent event on cpu %d: %ld\n",
> +		__func__, i, PTR_ERR(event));
> +
>  	while (--i >= 0)
>  		del_persistent_event(i, attr);

Should also be merged.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/