linux-kernel - Re: [PATCH] lib: digsig: Use ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 31 May 2013 17:41:48 +0300
From:	Dmitry Kasatkin <dmitry.s.kasatkin@...il.com>
To:	Alexandru Gheorghiu <gheorghiuandru@...il.com>
Cc:	James Morris <james.l.morris@...cle.com>,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>,
	linux-kernel@...r.kernel.org,
	Dmitry Kasatkin <dmitry.kasatkin@...il.com>
Subject: Re: [PATCH] lib: digsig: Use ERR_CAST function

Sorry. I am not at @intel.com any more. Did not see it.
I will use my private email for now..

Yes. This was bothering my eye for quite a while...

- Dmitry

On Fri, Apr 12, 2013 at 4:12 AM, Alexandru Gheorghiu
<gheorghiuandru@...il.com> wrote:
>
> Use ERR_CAST function instead of ERR_PTR and PTR_ERR.
> Patch found using coccinelle.
>
> Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@...il.com>
> ---
>  lib/digsig.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/digsig.c b/lib/digsig.c
> index 2f31e6a..8793aed 100644
> --- a/lib/digsig.c
> +++ b/lib/digsig.c
> @@ -209,7 +209,7 @@ int digsig_verify(struct key *keyring, const char
> *sig, int siglen,
>                 kref = keyring_search(make_key_ref(keyring, 1UL),
>                                                 &key_type_user, name);
>                 if (IS_ERR(kref))
> -                       key = ERR_PTR(PTR_ERR(kref));
> +                       key = ERR_CAST(kref);
>                 else
>                         key = key_ref_to_ptr(kref);
>         } else {
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/