linux-kernel - Re: [PATCH 2/2] spi: convert drivers to use bits_per_word

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51A8CB87.80201@wwwdotorg.org>
Date:	Fri, 31 May 2013 10:10:47 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Mark Brown <broonie@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	device-drivers-devel@...ckfin.uclinux.org,
	Mike Frysinger <vapier@...too.org>
Subject: Re: [PATCH 2/2] spi: convert drivers to use bits_per_word_mask

On 05/31/2013 02:45 AM, Arnd Bergmann wrote:
> Can you check this part again:
> 
> On Tuesday 21 May 2013 20:36:35 Stephen Warren wrote:
>> diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
...
>> @@ -1190,11 +1172,13 @@ static int pxa2xx_spi_probe(struct platform_device *pdev)
>>         drv_data->ioaddr = ssp->mmio_base;
>>         drv_data->ssdr_physical = ssp->phys_base + SSDR;
>>         if (pxa25x_ssp_comp(drv_data)) {
>> +               master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 16);
>>                 drv_data->int_cr1 = SSCR1_TIE | SSCR1_RIE;
>>                 drv_data->dma_cr1 = 0;
>>                 drv_data->clear_sr = SSSR_ROR;
>>                 drv_data->mask_sr = SSSR_RFS | SSSR_TFS | SSSR_ROR;
>>         } else {
>> +               master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32);
>>                 drv_data->int_cr1 = SSCR1_TIE | SSCR1_RIE | SSCR1_TINTE;
>>                 drv_data->dma_cr1 = DEFAULT_DMA_CR1;
>>                 drv_data->clear_sr = SSSR_ROR | SSSR_TINT;
> 
> I get a new build warning
> 
> drivers/spi/spi-pxa2xx.c: In function 'pxa2xx_spi_probe':
> drivers/spi/spi-pxa2xx.c:1152:3: warning: left shift count >= width of type [enabled by default]
>    master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32);
>    ^

That should be fixed by the patches I sent yesterday.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/