linux-kernel - Re: [PATCH] dtc: Ensure #line directives don't consume data from the next line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51A8E0EE.1040305@wwwdotorg.org>
Date:	Fri, 31 May 2013 11:42:06 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Andreas Schwab <schwab@...ux-m68k.org>
CC:	David Gibson <david@...son.dropbear.id.au>, jdl@....com,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, mmarek@...e.cz,
	rob.herring@...xeda.com, grant.likely@...retlab.ca,
	linux-kbuild@...r.kernel.org, Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH] dtc: Ensure #line directives don't consume data from
 the next line

On 05/31/2013 11:38 AM, Andreas Schwab wrote:
> Stephen Warren <swarren@...dotorg.org> writes:
> 
>> Fix this by replacing {WS} with [ \t] so that it can't match line-breaks.
> 
> I think the other uses of {WS} shouldn't span lines either.

That is true, but only the optional occurrence /should/ matter. Any
changes to the other occurrences would only affect malformed #line
directives, whereas changing this one occurrence would also affect
well-formed #line directives, due to the optional nature of the trailing
flags field.

Still, it may be reasonable just to change all the occurrences anyway.
Does anyone have a strong opinion either way?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/