[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1370036984.3928.144.camel@pasglop>
Date: Sat, 01 Jun 2013 07:49:44 +1000
From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
To: Zhao Chenhui <chenhui.zhao@...escale.com>
Cc: linuxppc-dev@...ts.ozlabs.org, scottwood@...escale.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/sysfs: disable hotplug for the boot cpu
On Tue, 2013-05-28 at 15:59 +0800, Zhao Chenhui wrote:
> Some features depend on the boot cpu, for instance, hibernate/suspend.
> So disable hotplug for the boot cpu.
Don't we have code to "move" the boot CPU around when that happens ?
Ben.
> Signed-off-by: Zhao Chenhui <chenhui.zhao@...escale.com>
> ---
> arch/powerpc/kernel/sysfs.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/sysfs.c b/arch/powerpc/kernel/sysfs.c
> index e68a845..294b1c4e 100644
> --- a/arch/powerpc/kernel/sysfs.c
> +++ b/arch/powerpc/kernel/sysfs.c
> @@ -655,8 +655,10 @@ static int __init topology_init(void)
> * CPU. For instance, the boot cpu might never be valid
> * for hotplugging.
> */
> - if (ppc_md.cpu_die)
> + if (ppc_md.cpu_die && cpu != boot_cpuid)
> c->hotpluggable = 1;
> + else
> + c->hotpluggable = 0;
>
> if (cpu_online(cpu) || c->hotpluggable) {
> register_cpu(c, cpu);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists