linux-kernel - Re: [PATCH] x86, msr/cpuid: Cocci spatch "ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 01 Jun 2013 07:49:49 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Thomas Meyer <thomas@...3r.de>, tglx@...utronix.de,
	mingo@...hat.com, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, msr/cpuid: Cocci spatch "ptr_ret.spatch"

This is not an acceptable patch... no description of any kind and a subject line which would only make sense if the cocci scripts are checked into the kernel tree.

Thomas Meyer <thomas@...3r.de> wrote:

>
>Signed-off-by: Thomas Meyer <thomas@...3r.de>
>---
>
>diff -u -p a/arch/x86/kernel/cpuid.c b/arch/x86/kernel/cpuid.c
>--- a/arch/x86/kernel/cpuid.c
>+++ b/arch/x86/kernel/cpuid.c
>@@ -143,7 +143,7 @@ static __cpuinit int cpuid_device_create
> 
> 	dev = device_create(cpuid_class, NULL, MKDEV(CPUID_MAJOR, cpu), NULL,
> 			    "cpu%d", cpu);
>-	return IS_ERR(dev) ? PTR_ERR(dev) : 0;
>+	return PTR_RET(dev);
> }
> 
> static void cpuid_device_destroy(int cpu)
>diff -u -p a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
>--- a/arch/x86/kernel/msr.c
>+++ b/arch/x86/kernel/msr.c
>@@ -206,7 +206,7 @@ static int __cpuinit msr_device_create(i
> 
> 	dev = device_create(msr_class, NULL, MKDEV(MSR_MAJOR, cpu), NULL,
> 			    "msr%d", cpu);
>-	return IS_ERR(dev) ? PTR_ERR(dev) : 0;
>+	return PTR_RET(dev);
> }
> 
> static void msr_device_destroy(int cpu)

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/