linux-kernel - Re: [PATCH] [SCSI] libsas: Cocci spatch "ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1370100403.2463.14.camel@dabdike>
Date:	Sat, 01 Jun 2013 08:26:43 -0700
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [SCSI] libsas: Cocci spatch "ptr_ret.spatch"

On Sat, 2013-06-01 at 11:59 +0200, Thomas Meyer wrote:
> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> ---
> 
> diff -u -p a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -1093,9 +1093,7 @@ int sas_init_queue(struct sas_ha_struct
>  
>  	core->queue_thread = kthread_run(sas_queue_thread, sas_ha,
>  					 "sas_queue_%d", core->shost->host_no);
> -	if (IS_ERR(core->queue_thread))
> -		return PTR_ERR(core->queue_thread);
> -	return 0;
> +	return PTR_RET(core->queue_thread);
>  }

Really, no, this is not a good patch.  I know exactly what the current
code is doing by reading it.  With your patch I now have to go and look
up the definition of an obscure and non-standard macro.

If we're sacrificing clarity, I want a good reason and having two lines
fewer code isn't it.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/