linux-kernel - Re: [PATCH v2 1/2] watchdog: xilinx: Fix driver header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130601152909.GB7751@roeck-us.net>
Date:	Sat, 1 Jun 2013 08:29:09 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	linux-kernel@...r.kernel.org, Michal Simek <monstr@...str.eu>,
	Wim Van Sebroeck <wim@...ana.be>,
	linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v2 1/2] watchdog: xilinx: Fix driver header

On Fri, May 31, 2013 at 07:56:33AM +0200, Michal Simek wrote:
> - Remove reference for IP version
> - Fix header coding style
> - Remove notes which are visible from the code
> - Fix driver license according to header
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> Changes in v2: None
> 
>  drivers/watchdog/of_xilinx_wdt.c | 30 ++++++++++--------------------
>  1 file changed, 10 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
> index 2761ddb..d4a35ab 100644
> --- a/drivers/watchdog/of_xilinx_wdt.c
> +++ b/drivers/watchdog/of_xilinx_wdt.c
> @@ -1,23 +1,13 @@
>  /*
> -*   of_xilinx_wdt.c  1.01  A Watchdog Device Driver for Xilinx xps_timebase_wdt
> -*
> -*   (C) Copyright 2011 (Alejandro Cabrera <aldaya@...il.com>)
> -*
> -*       -----------------------
> -*
> -*   This program is free software; you can redistribute it and/or
> -*   modify it under the terms of the GNU General Public License
> -*   as published by the Free Software Foundation; either version
> -*   2 of the License, or (at your option) any later version.
> -*
> -*       -----------------------
> -*	30-May-2011 Alejandro Cabrera <aldaya@...il.com>
> -*		- If "xlnx,wdt-enable-once" wasn't found on device tree the
> -*		  module will use CONFIG_WATCHDOG_NOWAYOUT
> -*		- If the device tree parameters ("clock-frequency" and
> -*		  "xlnx,wdt-interval") wasn't found the driver won't
> -*		  know the wdt reset interval
> -*/
> + * Watchdog Device Driver for Xilinx axi/xps_timebase_wdt
> + *
> + * (C) Copyright 2011 (Alejandro Cabrera <aldaya@...il.com>)
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */
> 
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> @@ -413,5 +403,5 @@ module_platform_driver(xwdt_driver);
> 
>  MODULE_AUTHOR("Alejandro Cabrera <aldaya@...il.com>");
>  MODULE_DESCRIPTION("Xilinx Watchdog driver");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
> --
> 1.8.2.3
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/