linux-kernel - Re: [PATCH 13/15] [media] omap3isp: include linux/mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3507557.BiLMFItQuE@avalon>
Date:	Sat, 01 Jun 2013 17:30:17 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-kernel@...r.kernel.org, patches@...ts.linaro.org,
	linux-arm-kernel@...ts.infradead.org,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	linux-media@...r.kernel.org,
	Konstantin Khlebnikov <khlebnikov@...nvz.org>
Subject: Re: [PATCH 13/15] [media] omap3isp: include linux/mm_types.h

Hi Arnd,

Thank you for the patch.

On Saturday 01 June 2013 00:22:50 Arnd Bergmann wrote:
> The ispqueue.h file uses vm_flags_t, which is defined in
> linux/mm_types.h, so we must include that header in order
> to build in all configurations.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Cc: Mauro Carvalho Chehab <mchehab@...hat.com>
> Cc: linux-media@...r.kernel.org
> Cc: Konstantin Khlebnikov <khlebnikov@...nvz.org>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

(with a minor nitpick below)

> ---
>  drivers/media/platform/omap3isp/ispqueue.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/omap3isp/ispqueue.h
> b/drivers/media/platform/omap3isp/ispqueue.h index 908dfd7..e6e720c 100644
> --- a/drivers/media/platform/omap3isp/ispqueue.h
> +++ b/drivers/media/platform/omap3isp/ispqueue.h
> @@ -31,6 +31,7 @@
>  #include <linux/mutex.h>
>  #include <linux/videodev2.h>
>  #include <linux/wait.h>
> +#include <linux/mm_types.h>

Could you please make sure the headers are sorted alphabetically ?

Would you like me to take the patch in my tree ? If so I'll sort the headers 
myself.

>  struct isp_video_queue;
>  struct page;

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/