linux-kernel - Re: [PATCH] usb: gadget: lpc32xx_udc: Cocci spatch "memdup.spatch"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130601165854.GA15095@arwen.pp.htv.fi>
Date:	Sat, 1 Jun 2013 19:58:54 +0300
From:	Felipe Balbi <balbi@...com>
To:	Thomas Meyer <thomas@...3r.de>
CC:	<balbi@...com>, <grant.likely@...aro.org>,
	<rob.herring@...xeda.com>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: lpc32xx_udc: Cocci spatch "memdup.spatch"

On Sat, Jun 01, 2013 at 11:36:46AM +0200, Thomas Meyer wrote:
> 

-ENOLOG

please add a commit log.

> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> ---
> 
> diff -u -p a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
> --- a/drivers/usb/gadget/lpc32xx_udc.c
> +++ b/drivers/usb/gadget/lpc32xx_udc.c
> @@ -3046,11 +3046,10 @@ static int __init lpc32xx_udc_probe(stru
>  	dma_addr_t dma_handle;
>  	struct device_node *isp1301_node;
>  
> -	udc = kzalloc(sizeof(*udc), GFP_KERNEL);
> +	udc = kmemdup(&controller_template, sizeof(*udc), GFP_KERNEL);
>  	if (!udc)
>  		return -ENOMEM;
>  
> -	memcpy(udc, &controller_template, sizeof(*udc));
>  	for (i = 0; i <= 15; i++)
>  		udc->ep[i].udc = udc;
>  	udc->gadget.ep0 = &udc->ep[0].ep;
> 
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)