linux-kernel - Re: [PATCH 05/11] spi: omap2-mcspi: enhance pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130601192726.GS16790@sirena.org.uk>
Date:	Sat, 1 Jun 2013 20:27:26 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Hebbar Gururaja <gururaja.hebbar@...com>
Cc:	khilman@...aro.org, grant.likely@...aro.org,
	linus.walleij@...aro.org, rob.herring@...xeda.com,
	davinci-linux-open-source@...ux.davincidsp.com,
	devicetree-discuss@...ts.ozlabs.org,
	linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
	linux-kernel@...r.kernel.org, vaibhav.bedia@...com,
	sudhakar.raj@...com, spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH 05/11] spi: omap2-mcspi: enhance pinctrl support

On Fri, May 31, 2013 at 03:43:05PM +0530, Hebbar Gururaja wrote:
> Amend the spi omap controller to optionally take a pin control
> handle and set the state of the pins to:
> 
> - "default" on boot, resume and before performing an spi transfer
> - "idle" after initial default, after resume default, and after each
> spi xfer
> - "sleep" on suspend()

Looking at this code I can't really see what's OMAP-specific about it -
exactly the same flow should apply to pretty much any SPI controller,
especially given that the code will happily ignore missing states.
We're just setting the idle state when not actively transferring data
which seems sensible and generic.

This suggests to me that we should be adding this code into the core,
probably joined up with the transfer_one_message stuff, so that any
hardware which has an idle state will be able to get the benefit.  Can
anyone think of a reason why we shouldn't do that?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)