[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130601040046.GB3868@quad.lixom.net>
Date: Fri, 31 May 2013 21:00:46 -0700
From: Olof Johansson <olof@...om.net>
To: Tushar Behera <tushar.behera@...aro.org>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, arnd@...db.de,
kgene.kim@...sung.com, patches@...aro.org
Subject: Re: [PATCH 2/3] ARM: SAMSUNG: Consolidate uncompress subroutine
On Fri, May 31, 2013 at 05:19:03PM +0530, Tushar Behera wrote:
> For mach-exynos, uart_base is a pointer and the value is calculated
> in the machine folder. For other machines, uart_base is defined as
> a macro in platform directory. For symmetry, the uart_base macro
> definition is removed and the uart_base calculation is moved to
> specific machine folders.
>
> This would help us consolidating uncompress subroutine for s5p64x0.
Sorry, reading these in order and didn't go through all of them.
Same comment here, you can use config_enabled() and return early instead of
adding ifdefs.
-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists