| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1370061602.3766.22.camel@pasglop> Date: Sat, 01 Jun 2013 14:40:02 +1000 From: Benjamin Herrenschmidt <benh@...nel.crashing.org> To: Aruna Balakrishnaiah <aruna@...ux.vnet.ibm.com> Cc: linuxppc-dev@...abs.org, paulus@...ba.org, linux-kernel@...r.kernel.org, jkenisto@...ux.vnet.ibm.com, tony.luck@...el.com, ananth@...ibm.com, mahesh@...ux.vnet.ibm.com, ccross@...roid.com, anton@...ba.org, cbouatmailru@...il.com, keescook@...omium.org Subject: Re: [PATCH v3 0/8] Nvram-to-pstore On Thu, 2013-04-25 at 15:47 +0530, Aruna Balakrishnaiah wrote: > Currently the kernel provides the contents of p-series NVRAM only as a > simple stream of bytes via /dev/nvram, which must be interpreted in user > space by the nvram command in the powerpc-utils package. This patch set > exploits the pstore subsystem to expose each partition in NVRAM as a > separate file in /dev/pstore. For instance Oops messages will stored in a > file named [dmesg-nvram-2]. We will need the same stuff for powernv. This is not a blocker for this patch series which I'm happy to apply (after I give it another round of review, hopefully today) but I would very much like you to, on top of this, start moving some of the basic pseries partition nvram handling to a generic place, along with your pstore bits, and use it on powernv as well. In fact, this applies to at least all the BookS server platforms... Things that come to mind: - nvram_64.c duplicates generic_nvram.c as far as the user accessors are concerned, it should be possible to get rid of code there. Either the arch or the generic one (*) - The nvram partition management should move to generic. While at it factor in the powermac variant (same stuff, mostly duplicated code) - powernv wants all the goodies that pseries has, as does cell. (*) I wonder about that generic stuff... userspace might want to start doing things like resizing the common partition if not big enough etc... For that we might want to add more specific ioctl's. Is anybody other than us using generic_nvram ? I don't like adding ioctl's like that to a generic driver, maybe we could just make it call into something like arch_nvram_ioctl() and have an empty weak variant instead of the current ifdef game. Cheers, Ben. > Changes from v2: > - Fix renaming of pstore type ids in nvram.c > > Changes from v1: > - Reduce #ifdefs by and remove forward declarations of pstore callbacks > - Handle return value of nvram_write_os_partition > - Remove empty pstore callbacks and register pstore only when pstore > is configured > --- > > Aruna Balakrishnaiah (8): > powerpc/pseries: Remove syslog prefix in uncompressed oops text > powerpc/pseries: Add version and timestamp to oops header > powerpc/pseries: Introduce generic read function to read nvram-partitions > powerpc/pseries: Read/Write oops nvram partition via pstore > powerpc/pseries: Read rtas partition via pstore > powerpc/pseries: Distinguish between a os-partition and non-os partition > powerpc/pseries: Read of-config partition via pstore > powerpc/pseries: Read common partition via pstore > > > arch/powerpc/platforms/pseries/nvram.c | 353 +++++++++++++++++++++++++++----- > fs/pstore/inode.c | 9 + > include/linux/pstore.h | 4 > 3 files changed, 313 insertions(+), 53 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists