linux-kernel - Re: [PATCH] power: replace strict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdKTmoe4=Pb=Q7xGWm-js=grVELa8FVhYDv6GR-8VGW4w@mail.gmail.com>
Date:	Sun, 2 Jun 2013 13:36:21 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	Anton Vorontsov <cbou@...l.ru>,
	Anton Vorontsov <avorontsov@...mvista.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] power: replace strict_strtoul() with kstrtoul()

On Sat, Jun 1, 2013 at 10:27 AM, Jingoo Han <jg1.han@...sung.com> wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.

> --- a/drivers/power/ab8500_fg.c
> +++ b/drivers/power/ab8500_fg.c
> @@ -2467,7 +2467,7 @@ static ssize_t charge_full_store(struct ab8500_fg *di, const char *buf,
>         unsigned long charge_full;
>         ssize_t ret = -EINVAL;

Redundant assignment.

> --- a/drivers/power/pcf50633-charger.c
> +++ b/drivers/power/pcf50633-charger.c
> @@ -191,7 +191,7 @@ static ssize_t set_usblim(struct device *dev,
>         unsigned long ma;
>         int ret;
>
> -       ret = strict_strtoul(buf, 10, &ma);
> +       ret = kstrtoul(buf, 10, &ma);
>         if (ret)
>                 return -EINVAL;

return ret;

> @@ -228,7 +228,7 @@ static ssize_t set_chglim(struct device *dev,
>         if (!mbc->pcf->pdata->charger_reference_current_ma)
>                 return -ENODEV;
>
> -       ret = strict_strtoul(buf, 10, &ma);
> +       ret = kstrtoul(buf, 10, &ma);
>         if (ret)
>                 return -EINVAL;

Ditto.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/