lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 2 Jun 2013 14:56:02 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Jingoo Han <jg1.han@...sung.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Alessandro Zummo <a.zummo@...ertech.it>, rtc-linux@...glegroups.com Subject: Re: [PATCH] rtc: rtc-pcf2123: replace strict_strtoul() with kstrtoul() On Sat, Jun 1, 2013 at 10:31 AM, Jingoo Han <jg1.han@...sung.com> wrote: > The usage of strict_strtoul() is not preferred, because > strict_strtoul() is obsolete. Thus, kstrtoul() should be > used. > --- a/drivers/rtc/rtc-pcf2123.c > +++ b/drivers/rtc/rtc-pcf2123.c > @@ -94,7 +94,7 @@ static ssize_t pcf2123_show(struct device *dev, struct device_attribute *attr, > > r = container_of(attr, struct pcf2123_sysfs_reg, attr); > > - if (strict_strtoul(r->name, 16, ®)) > + if (kstrtoul(r->name, 16, ®)) > return -EINVAL; ret = kstrtoul(...); if (ret) return ret; > @@ -117,8 +117,7 @@ static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr, > > r = container_of(attr, struct pcf2123_sysfs_reg, attr); > > - if (strict_strtoul(r->name, 16, ®) > - || strict_strtoul(buffer, 10, &val)) > + if (kstrtoul(r->name, 16, ®) || kstrtoul(buffer, 10, &val)) > return -EINVAL; I see no harm to allow user to write octal values as well. Thus, just ret = kstrtoul(r->name, 0, ®); if (ret) return ret; Alessandro, what do you think? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists