linux-kernel - Re: [PATCH] firewire: introduce fw_driver.probe and .remove methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Jun 2013 01:35:02 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Takashi Sakamoto <o-takashi@...amocchi.jp>,
	linux1394-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Clemens Ladisch <clemens@...isch.de>,
	Peter Hurley <peter@...leysoftware.com>
Subject: Re: [PATCH] firewire: introduce fw_driver.probe and .remove methods

On Jun 02 Greg Kroah-Hartman wrote:
> On Mon, Jun 03, 2013 at 12:27:49AM +0200, Stefan Richter wrote:
> > Although all in-tree drivers are being converted to the new methods,
> > support for the old methods is left in place for the time being, aiming
> > to avoid conflicts if/when new drivers are being merged into the
> > mainline via other trees.
> 
> Are there other firewire drivers in other trees in linux-next right now?
> If not, I'd just recommend converting everything over and not using the
> old functions at all.  Especially as there really isn't that many
> firewire drivers, and new ones are pretty rare these days, right?

I think there is none in -next at the moment.  But Sakamoto-san posted an
RFC just two days ago:
http://mailman.alsa-project.org/pipermail/alsa-devel/2013-June/062614.html

This is one of two(?) drivers on which he is currently working on; the
other one is the one which is going to need the new id argument
in .probe().  And then there is another person working on yet another
sound/firewire/ driver, but upstreaming of that driver might take a
little more time for some more integration steps, from what I heard.

So, alternatively I could fold "firewire: remove support of
fw_driver.driver.probe and .remove methods" into this one and commit it to
a stable topic branch in linux1394.git (to be merged early after 3.10),
and the audio driver developers could pull this topic branch if they want
to and when they want to.

> Other than that, your patch looks good.

Thanks for review.
-- 
Stefan Richter
-=====-===-= -==- ---==
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/