linux-kernel - Re: [PATCH] tg3: remove redundant pm init code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130603.001301.239203578028894121.davem@davemloft.net>
Date:	Mon, 03 Jun 2013 00:13:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wangyijing@...wei.com
Cc:	nsujir@...adcom.com, mchan@...adcom.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	guohanjun@...wei.com, liuj97@...il.com
Subject: Re: [PATCH] tg3: remove redundant pm init code

From: Yijing Wang <wangyijing@...wei.com>
Date: Wed, 29 May 2013 17:00:32 +0800

> Pci_enable_device() will set device pm state to D0, so
> it's no need to do it again in tg3_init_one().
> 
> Signed-off-by: Yijing Wang <wangyijing@...wei.com>

This patch introduces a warning:

drivers/net/ethernet/broadcom/tg3.c: In function ‘tg3_init_one’:
drivers/net/ethernet/broadcom/tg3.c:17231:13: warning: ‘pm_cap’ may be used uninitialized in this function [-Wuninitialized]