linux-kernel - Re: [PATCH 2/2] mfd: ssbi: Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130603081021.GA3370@gmail.com>
Date:	Mon, 3 Jun 2013 09:10:21 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, David Brown <davidb@...eaurora.org>
Subject: Re: [PATCH 2/2] mfd: ssbi: Use devm_* to simplify code

> Use devm_ioremap_resource and devm_kzalloc to simplify error
> paths and reduce lines of code.

The code looks fine, but you're actually doing a great deal more than
you describe in the commit message. Would you mind expanding?

I.e:

> +		dev_err(&pdev->dev, "Unknown qcom,controller-type\n");

Switching to these 'cos they're more informative.

> -	platform_set_drvdata(pdev, NULL);

Removing these because they're obsolete.

> -	.remove		= ssbi_remove,

Removing this 'cos it no longer does anything useful.

> +module_platform_driver(ssbi_driver);

Moving these because it's more succinct when init() and exit()
routines are baron.

None of the above have anything to do with devm_* managed resources.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/