linux-kernel - Re: [PATCH] include/linux/skbuff.h: using '0xffff' instead of '~0U'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51AC593E.4070503@asianux.com>
Date:	Mon, 03 Jun 2013 16:52:14 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	edumazet@...gle.com, Pravin Shelar <pshelar@...ira.com>,
	mgorman@...e.de, David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] include/linux/skbuff.h: using '0xffff' instead of '~0U'

On 05/30/2013 11:30 PM, Ben Hutchings wrote:
> On Thu, 2013-05-30 at 14:03 +0800, Chen Gang wrote:
>> > Both 'transport_header' and 'mac_header' are u16, which are never equal
>> > to '~0U'.
>> > 
>> > So need use '0xffff' instead of '~0U'.
> ..and give this magic number a name?

It sounds a good idea. I will check which name is suitable for it, then
send patch v2, and please help to check it, too.


Thanks.
-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/