[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1370252643.11717.27.camel@zakaz.uk.xensource.com>
Date: Mon, 3 Jun 2013 10:44:03 +0100
From: Ian Campbell <Ian.Campbell@...rix.com>
To: Grant Likely <grant.likely@...retlab.ca>
CC: Stephen Warren <swarren@...dotorg.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
Michal Marek <mmarek@...e.cz>,
"Stephen Warren" <swarren@...dia.com>,
Rob Herring <rob.herring@...xeda.com>,
JonLoeliger <jdl@....com>, <linux-kbuild@...r.kernel.org>
Subject: Re: DTB build failure due to preproccessing
On Fri, 2013-05-31 at 17:31 +0100, Grant Likely wrote:
> On Fri, May 31, 2013 at 5:04 PM, Stephen Warren <swarren@...dotorg.org> wrote:
> > On 05/31/2013 05:48 AM, Grant Likely wrote:
> >> ---
> >> commit d01dccdcb3ea8233b09efb9c24db9f057fbd3b37
> >> Author: Grant Likely <grant.likely@...aro.org>
> >> Date: Fri May 31 12:45:18 2013 +0100
> >>
> >> dtc: Suppress cpp linemarker annotations
> >>
> >> DTC isn't able to parse cpp linemarker annotations, so suppress them in
> >> the cpp output by adding the -P flag to the cpp options.
> >
> > That's not true; it explicitly does have code to parse the line markers.
> > I'll have to investigate why it isn't working in this case.
> >
> > If you apply this patch, then anyone who has switched to #include rther
> > than /include/ will get incorrect line numbers in dtc error messages.
> > Admittedly that's a smaller population right now though. Perhaps we
> > should just do a kernel-wide conversion though.
>
> My mistake. I tested the wrong thing. I've dropped the patch.
FWIW I've also dropped it from my device-tree.git tree.
Ian.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists