linux-kernel - Re: [PATCH V2 2/8] pktcdvd: Convert printk to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdri=6e5Jd8Qd29B7hx+mSjp5EzbooV8FA3MnXaoMGzwg@mail.gmail.com>
Date:	Mon, 3 Jun 2013 13:42:06 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Joe Perches <joe@...ches.com>, Jiri Kosina <jkosina@...e.cz>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 2/8] pktcdvd: Convert printk to pr_<level>

On Mon, Jun 3, 2013 at 12:57 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Fri, May 31, 2013 at 09:11:23PM -0700, Joe Perches wrote:
>> +static const char *sense_key_string(__u8 index)
>> +{
>> +     static const char *info[9] = {
>> +             "No sense", "Recovered error", "Not ready",
>> +             "Medium error", "Hardware error", "Illegal request",
>> +             "Unit attention", "Data protect", "Blank check"
>> +     };
>> +     if (index < 8)
>
> Off by one:
>
>         if (index < 9)

Perhaps
if (index < ARRAY_SIZE(info)) ?

I actually didn't test this, if it returns number of strings.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/