linux-kernel - Re: [PATCH V2] power: replace strict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdrhi=sX_MxeT6oqW6s8bbxqWr+rw4PsCYSepw+yffXWg@mail.gmail.com>
Date:	Mon, 3 Jun 2013 13:49:49 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	Anton Vorontsov <cbou@...l.ru>,
	Anton Vorontsov <avorontsov@...mvista.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] power: replace strict_strtoul() with kstrtoul()

On Mon, Jun 3, 2013 at 12:05 PM, Jingoo Han <jg1.han@...sung.com> wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

Looks better.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> ---
> Changes since v1:
> - Used return code from kstrtoul().
>
>  drivers/power/ab8500_fg.c        |    6 +++---
>  drivers/power/pcf50633-charger.c |    8 ++++----
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
> index c5391f5..308e511 100644
> --- a/drivers/power/ab8500_fg.c
> +++ b/drivers/power/ab8500_fg.c
> @@ -2465,9 +2465,9 @@ static ssize_t charge_full_store(struct ab8500_fg *di, const char *buf,
>                                  size_t count)
>  {
>         unsigned long charge_full;
> -       ssize_t ret = -EINVAL;
> +       ssize_t ret;
>
> -       ret = strict_strtoul(buf, 10, &charge_full);
> +       ret = kstrtoul(buf, 10, &charge_full);
>
>         dev_dbg(di->dev, "Ret %zd charge_full %lu", ret, charge_full);
>
> @@ -2489,7 +2489,7 @@ static ssize_t charge_now_store(struct ab8500_fg *di, const char *buf,
>         unsigned long charge_now;
>         ssize_t ret;
>
> -       ret = strict_strtoul(buf, 10, &charge_now);
> +       ret = kstrtoul(buf, 10, &charge_now);
>
>         dev_dbg(di->dev, "Ret %zd charge_now %lu was %d",
>                 ret, charge_now, di->bat_cap.prev_mah);
> diff --git a/drivers/power/pcf50633-charger.c b/drivers/power/pcf50633-charger.c
> index 17fd77f..771c4f0 100644
> --- a/drivers/power/pcf50633-charger.c
> +++ b/drivers/power/pcf50633-charger.c
> @@ -191,9 +191,9 @@ static ssize_t set_usblim(struct device *dev,
>         unsigned long ma;
>         int ret;
>
> -       ret = strict_strtoul(buf, 10, &ma);
> +       ret = kstrtoul(buf, 10, &ma);
>         if (ret)
> -               return -EINVAL;
> +               return ret;
>
>         pcf50633_mbc_usb_curlim_set(mbc->pcf, ma);
>
> @@ -228,9 +228,9 @@ static ssize_t set_chglim(struct device *dev,
>         if (!mbc->pcf->pdata->charger_reference_current_ma)
>                 return -ENODEV;
>
> -       ret = strict_strtoul(buf, 10, &ma);
> +       ret = kstrtoul(buf, 10, &ma);
>         if (ret)
> -               return -EINVAL;
> +               return ret;
>
>         mbcc5 = (ma << 8) / mbc->pcf->pdata->charger_reference_current_ma;
>         if (mbcc5 > 255)
> --
> 1.7.10.4
>
>



--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/