linux-kernel - Re: [PATCH v8 net-next 0/7] net: low latency Ethernet device polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51AC7CC0.6020205@mellanox.com>
Date:	Mon, 3 Jun 2013 14:23:44 +0300
From:	Amir Vadai <amirv@...lanox.com>
To:	Eliezer Tamir <eliezer.tamir@...ux.intel.com>
CC:	David Miller <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	<e1000-devel@...ts.sourceforge.net>,
	Willem de Bruijn <willemb@...gle.com>,
	Eric Dumazet <erdnetdev@...il.com>,
	Ben Hutchings <bhutchings@...arflare.com>,
	Andi Kleen <andi@...stfloor.org>, HPA <hpa@...or.com>,
	Eilon Greenstien <eilong@...adcom.com>,
	Or Gerlitz <or.gerlitz@...il.com>,
	Alex Rosenbaum <alexr@...lanox.com>,
	Eliezer Tamir <eliezer@...ir.org.il>
Subject: Re: [PATCH v8 net-next 0/7] net: low latency Ethernet device polling

Acked-By: Amir Vadai <amirv@...lanox.com>

Nice work Eliezer :)

On 03/06/2013 11:01, Eliezer Tamir wrote:
> David,
> 
> Here is v8 with yet more fixes.
> 
> Please consider applying.
> 
> Thanks to everyone for their input.
> 
> -Eliezer
> 
> change log:
> v8
> - split out udp and select/poll into seperate patches.
>   what used to be patch 2/5 is now three patches.
> - type corrections from Amir Vadai and Cong Wang:
>   one unsigned long that was left when chenging to cycles_t
>   int -> bool 
> - more detailed patch descriptions.
> 
> v7
> - suggested by Ben Hutchings and Eric Dumazet:
>   type fixes, static for globals in net/core.c,
>   avoid napi_id collisions in napi_hash_add()
> 
> v6
> - many small fixes suggested by Eric Dumazet:
>   data locality, typos, documentation
>   protect napi_hash insert/delete with a spinlock (napi_gen_id is no
>   longer atomic_t since it's only accessed with the spinlock held.)
> - added IPv6 TCP and UDP support (only minimally tested)
> 
> v5
> - corrections suggested by Ben Hutchings:
>   fixed typos, moved the config option and sysctl value from IPv4 to net
> - moved sk_mark_ll() to the protocol handlers
> - removed global id mechanism, replaced with a hashed napi_id.
>   based on code sample from Eric Dumazet
>   Note that ixgbe_free_q_vector() already waits an rcu grace period
>   before freeing the q_vector, so nothing additional needs to be done
>   when adding a call to napi_hash_del().
> - simple poll/select support
> 
> v4
> - removed separate config option for TCP as suggested Eric Dumazet.
> - added linux mib counter for packets received through the low latency path,
>   as suggested by Andi Kleen.
> - re-allow module unloading, remove module param, use a global generation id
>   instead to prevent the use of a stale napi pointer, as suggested
>   by Eric Dumazet
> - updated Documentation/networking/ip-sysctl.txt text
> 
> v3
> - coding style changes suggested by Dave Miller
> 
> v2
> - the sysctl knob is now in microseconds. The default value is now 0 (off).
> - for now the code depends at configure time on CONFIG_I86_TSC 
> - the napi reference in struct skb is now a union with the dma cookie
>   since the former is only used on RX and the latter on TX,
>   as suggested by Eric Dumazet.
> - we do a better job at honoring non-blocking operations.
> - removed busy-polling support for tcp_read_sock()
> - remove dynamic disabling of GRO
> - coding style fixes
> - disallow unloading the device module after the feature has been used
> 
> Credit:
> Jesse Brandeburg, Arun Chekhov Ilango, Julie Cummings,
> Alexander Duyck, Eric Geisler, Jason Neighbors, Yadong Li,
> Mike Polehn, Anil Vasudevan, Don Wood
> Special thanks for finding bugs in earlier versions:
> Willem de Bruijn and Andi Kleen
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/