linux-kernel - Re: [PATCH] HID: hyperv: Cocci spatch "memdup.spatch"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1306031334040.6750@pobox.suse.cz>
Date:	Mon, 3 Jun 2013 13:34:38 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	kys@...rosoft.com, haiyangz@...rosoft.com,
	devel@...uxdriverproject.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: hyperv: Cocci spatch "memdup.spatch"

On Sat, 1 Jun 2013, Thomas Meyer wrote:

> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> ---
> 
> diff -u -p a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -199,13 +199,11 @@ static void mousevsc_on_receive_device_i
>  	if (desc->bLength == 0)
>  		goto cleanup;
>  
> -	input_device->hid_desc = kzalloc(desc->bLength, GFP_ATOMIC);
> +	input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC);
>  
>  	if (!input_device->hid_desc)
>  		goto cleanup;
>  
> -	memcpy(input_device->hid_desc, desc, desc->bLength);
> -
>  	input_device->report_desc_size = desc->desc[0].wDescriptorLength;
>  	if (input_device->report_desc_size == 0) {
>  		input_device->dev_info_status = -EINVAL;
> 

I guess you are going to get some pushback from some maintainers due to 
non-descriptive subject and missing changelog :)

I have fixed this for the hyperv patch and applied it, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/