lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 03 Jun 2013 05:26:27 -0700 From: Joe Perches <joe@...ches.com> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: Ryan Mallon <rmallon@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@...el.com>, Grant Likely <grant.likely@...retlab.ca>, Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org, David Cohen <david.a.cohen@...el.com>, Grant Likely <grant.likely@...aro.org> Subject: Re: [PATCH v1.1] gpiolib: append SFI helpers for GPIO API On Mon, 2013-06-03 at 11:16 +0300, Andy Shevchenko wrote: > On Sun, 2013-06-02 at 19:06 -0700, Joe Perches wrote: > > On Mon, 2013-06-03 at 11:59 +1000, Ryan Mallon wrote: > > > On 31/05/13 19:27, Andy Shevchenko wrote: > > > > + sfi_gpio_table = kmalloc(num * sizeof(*pentry), GFP_KERNEL); > > > Use kcalloc when you have a size and a count. > > kmalloc_array unless you want zero'ed memory > One proposed to use kmemdup to clean up a bit. What do you think? Seems correct to use kmemdup but what validates num? It seems like a possible error path exists there regardless of whether kmemdup is used or not. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists