linux-kernel - Re: [PATCH] eCryptfs: Cocci spatch "memdup.spatch"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130603024747.GA10466@boyd>
Date:	Sun, 2 Jun 2013 19:47:47 -0700
From:	Tyler Hicks <tyhicks@...onical.com>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	ecryptfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eCryptfs: Cocci spatch "memdup.spatch"

On 2013-06-01 11:39:36, Thomas Meyer wrote:
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> ---

Thanks Thomas - I've pushed this to my next branch.

Tyler

> 
> diff -u -p a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
> --- a/fs/ecryptfs/messaging.c
> +++ b/fs/ecryptfs/messaging.c
> @@ -247,14 +247,13 @@ int ecryptfs_process_response(struct ecr
>  		goto unlock;
>  	}
>  	msg_size = (sizeof(*msg) + msg->data_len);
> -	msg_ctx->msg = kmalloc(msg_size, GFP_KERNEL);
> +	msg_ctx->msg = kmemdup(msg, msg_size, GFP_KERNEL);
>  	if (!msg_ctx->msg) {
>  		rc = -ENOMEM;
>  		printk(KERN_ERR "%s: Failed to allocate [%zd] bytes of "
>  		       "GFP_KERNEL memory\n", __func__, msg_size);
>  		goto unlock;
>  	}
> -	memcpy(msg_ctx->msg, msg, msg_size);
>  	msg_ctx->state = ECRYPTFS_MSG_CTX_STATE_DONE;
>  	wake_up_process(msg_ctx->task);
>  	rc = 0;
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ecryptfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)