linux-kernel - Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130603133633.GA18391@zod>
Date:	Mon, 3 Jun 2013 09:36:33 -0400
From:	Josh Boyer <jwboyer@...il.com>
To:	Ian Campbell <ian.campbell@...rix.com>
Cc:	linux-kernel@...r.kernel.org, Tirumala R Marri <tmarri@....com>,
	Rupjyoti Sarmah <rsarmah@....com>,
	Josh Boyer <jwboyer@...ux.vnet.ibm.com>,
	Paul Mackerras <paulus@...ba.org>,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote:
>Currently I see:
>  DTC     arch/powerpc/boot/kilauea.dtb
>Warning (reg_format): "reg" property in /plb/ppc4xx-msi@...000000 has invalid length (12 bytes) (#address-cells == 1, #size-cells == 1)
>
>It appears that unlike the other plarforms handled by 3fb7933850fa
>"powerpc/4xx: Adding PCIe MSI support" this platform does not use address-cells=2.

Right, it's a 405, not a 440.  I should have caught that in the initial
review.

>Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
>Cc: Rupjyoti Sarmah <rsarmah@....com>
>Cc: Tirumala R Marri <tmarri@....com>
>Cc: Josh Boyer <jwboyer@...ux.vnet.ibm.com>

That address should bounce.  It hasn't been active in almost 2 years.

>Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>Cc: Paul Mackerras <paulus@...ba.org>
>Cc: linuxppc-dev@...ts.ozlabs.org
>Cc: linux-kernel@...r.kernel.org

Acked-by: Josh Boyer <jwboyer@...il.com>

>---
> arch/powerpc/boot/dts/kilauea.dts |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/powerpc/boot/dts/kilauea.dts b/arch/powerpc/boot/dts/kilauea.dts
>index 1613d6e..5ba7f01 100644
>--- a/arch/powerpc/boot/dts/kilauea.dts
>+++ b/arch/powerpc/boot/dts/kilauea.dts
>@@ -406,7 +406,7 @@
> 
> 		MSI: ppc4xx-msi@...000000 {
> 			compatible = "amcc,ppc4xx-msi", "ppc4xx-msi";
>-			reg = < 0x0 0xEF620000 0x100>;
>+			reg = <0xEF620000 0x100>;
> 			sdr-base = <0x4B0>;
> 			msi-data = <0x00000000>;
> 			msi-mask = <0x44440000>;
>-- 
>1.7.10.4
>
>_______________________________________________
>Linuxppc-dev mailing list
>Linuxppc-dev@...ts.ozlabs.org
>https://lists.ozlabs.org/listinfo/linuxppc-dev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/