lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 03 Jun 2013 17:29:52 +0200 From: Arnd Bergmann <arnd@...db.de> To: Lee Jones <lee.jones@...aro.org> Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linus.walleij@...ricsson.com, srinidhi.kasagar@...ricsson.com, ulf.hansson@...aro.org Subject: Re: [PATCH 08/21] ARM: ux500: Supply the I2C clocks lookup to the DBX500 DT On Monday 03 June 2013 15:27:55 Lee Jones wrote: > On Mon, 03 Jun 2013, Arnd Bergmann wrote: > > > On Monday 03 June 2013 14:42:32 Lee Jones wrote: > > > @@ -559,6 +559,8 @@ > > > v-i2c-supply = <&db8500_vape_reg>; > > > > > > clock-frequency = <400000>; > > > + clocks = <&clk 100>, <&clk 67>; > > > + clock-names = "nmk-i2c.0", "apb_pclk"; > > > }; > > > > > > i2c@...22000 { > > > @@ -572,6 +574,9 @@ > > > v-i2c-supply = <&db8500_vape_reg>; > > > > > > clock-frequency = <400000>; > > > + > > > + clocks = <&clk 85>, <&clk 42>; > > > + clock-names = "nmk-i2c.1", "apb_pclk"; > > > }; > > > > Same comment actually as for the uart patch, also SDI and MSP > > have the same problem. > > I was only using the names in the same manor as the API does, to fetch > the 'clocks =' index. Do you mean that I should be using 'uartclk', > 'i2cclk', 'sdmmcclk' and 'msp1clk' instead? Yes, that would be better. I suppose you can actually leave out the 'clk' part and just call them 'i2c', 'sdmmc', 'msp' and 'uart', but you should check if any of the driver already specify the clock names in their DT bindings. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists