| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1370274140-26420-5-git-send-email-jiang.liu@huawei.com> Date: Mon, 3 Jun 2013 23:42:16 +0800 From: Jiang Liu <liuj97@...il.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Nitin Gupta <ngupta@...are.org>, Minchan Kim <minchan@...nel.org>, Jerome Marchand <jmarchan@...hat.com> Cc: Yijing Wang <wangyijing@...wei.com>, Jiang Liu <jiang.liu@...wei.com>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: [RFC PATCH v1 4/8] zram: destroy all devices on error recovery path in zram_init() On error recovery path of zram_init(), it leaks the zram device object causing the failure. Signed-off-by: Jiang Liu <jiang.liu@...wei.com> --- drivers/staging/zram/zram_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index 0738f6c..3d90344 100644 --- a/drivers/staging/zram/zram_drv.c +++ b/drivers/staging/zram/zram_drv.c @@ -712,8 +712,8 @@ static int __init zram_init(void) return 0; free_devices: - while (dev_id) - destroy_device(&zram_devices[--dev_id]); + while (dev_id >= 0) + destroy_device(&zram_devices[dev_id--]); kfree(zram_devices); unregister: unregister_blkdev(zram_major, "zram"); -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists