linux-kernel - RE: [RFC PATCH 1/1] mwifiex: Remove stop_net_dev_queue operation when uap handling packets forwarding.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <477F20668A386D41ADCC57781B1F70430E805C627A@SC-VEXCH1.marvell.com>
Date:	Mon, 3 Jun 2013 11:24:15 -0700
From:	Bing Zhao <bzhao@...vell.com>
To:	Huawei Yang <harvey.huawei.yang@...il.com>
CC:	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Avinash Patil <patila@...vell.com>
Subject: RE: [RFC PATCH 1/1] mwifiex: Remove stop_net_dev_queue operation
 when uap handling packets forwarding.

Hi Huawei,

Thanks for the patch.

> Under uap mode mwifiex may stop all net tx queues on forwarding packets. This may stop some tx queues
> and they never have chance to be waked up... There is also no need to check tx_pending and stop
> queues here. Because local host has such kind of check when transmitting packets and it's not proper
> to have forwarding affect local transmitting.
> 
> Signed-off-by: Huawei Yang <harvey.huawei.yang@...il.com>

Reviewed-by: Avinash Patil <patila@...vell.com>
Acked-by: Bing Zhao <bzhao@...vell.com>

Thanks,
Bing

> ---
>  drivers/net/wireless/mwifiex/uap_txrx.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/mwifiex/uap_txrx.c b/drivers/net/wireless/mwifiex/uap_txrx.c
> index a018e42..11df2b2 100644
> --- a/drivers/net/wireless/mwifiex/uap_txrx.c
> +++ b/drivers/net/wireless/mwifiex/uap_txrx.c
> @@ -95,10 +95,6 @@ static void mwifiex_uap_queue_bridged_pkt(struct mwifiex_private *priv,
>  	atomic_inc(&adapter->tx_pending);
>  	atomic_inc(&adapter->pending_bridged_pkts);
> 
> -	if ((atomic_read(&adapter->tx_pending) >= MAX_TX_PENDING)) {
> -		mwifiex_set_trans_start(priv->netdev);
> -		mwifiex_stop_net_dev_queue(priv->netdev, priv->adapter);
> -	}
>  	return;
>  }
> 
> --
> 1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/