linux-kernel - Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130603190815.GB1820@kroah.com>
Date:	Mon, 3 Jun 2013 12:08:15 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Ben Chan <benchan@...omium.org>
Cc:	devel@...verdev.osuosl.org, Sage Ahn <syahn@...semi.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either
 USB or MMC

On Mon, Jun 03, 2013 at 11:30:45AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
> > The gdm72xx driver needs to have either the USB or SDIO implementation
> > enabled to provide useful functionalities, so the driver should depend
> > on either USB or MMC.
> > 
> > Signed-off-by: Ben Chan <benchan@...omium.org>
> > Cc: Sage Ahn <syahn@...semi.com>
> > ---
> >  drivers/staging/gdm72xx/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
> > index 6905913..8af0dd4 100644
> > --- a/drivers/staging/gdm72xx/Kconfig
> > +++ b/drivers/staging/gdm72xx/Kconfig
> > @@ -4,7 +4,7 @@
> >  
> >  menuconfig WIMAX_GDM72XX
> >  	tristate "GCT GDM72xx WiMAX support"
> > -	depends on NET
> > +	depends on NET && (USB || MMC)
> 
> Really?  Again?
> 
> Are you trying to just get me to ignore your patches?
> 
> If so, you just did a good job, please take a day or two to relax and
> get it right.

Crap, slow mailing list, just decided to spit out the second copy of
this to me, sorry for the rant, I need more coffee.

Or maybe less...

My apologies.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/