linux-kernel - Re: [PATCH] mfd: twl-core: convert to module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87li6qlxno.fsf@linaro.org>
Date:	Mon, 03 Jun 2013 13:58:03 -0700
From:	Kevin Hilman <khilman@...aro.org>
To:	"Strashko\, Grygorii" <grygorii.strashko@...com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Tony Lindgren <tony@...mide.com>,
	"linux-omap\@vger.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: twl-core: convert to module_init()

"Strashko, Grygorii" <grygorii.strashko@...com> writes:

> Hi Kevin,
>
> It's done alreday here:
> https://patchwork.kernel.org/patch/2477541/ - mfd: twl-core: convert to module_i2c_driver()
>  (Samuel has taken this one)

Excellent, thanks for pointing it out, somehow I missed that thread.  My
patch can be ignored.

> - and -
> https://patchwork.kernel.org/patch/2477561/ - i2c: omap: convert to module_platform_driver()
>  (you can vote here - TWL can't be shifted without I2C)

This one (combined with the first one) makes twl_rtc fail to initialize
properly on OMAP3 DT boot, with an error like this:

         twl_rtc rtc.22: hctosys: invalid date/time

Reverting that you get the expected result:

          twl_rtc rtc.22: setting system clock to 2000-01-01 00:00:00 UTC (946684800)

I didn't debug any further, but for now, at least patch 2 needs a little
more work/debug.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/