linux-kernel - Re: [PATCH v4 3/6] staging: android: binder: fix BINDER_SET_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130603223903.GA16711@kroah.com>
Date:	Mon, 3 Jun 2013 15:39:03 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Arve Hjønnevåg <arve@...roid.com>
Cc:	Serban Constantinescu <serban.constantinescu@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Android Kernel Team <kernel-team@...roid.com>,
	John Stultz <john.stultz@...aro.org>,
	Dave Butcher <Dave.Butcher@....com>
Subject: Re: [PATCH v4 3/6] staging: android: binder: fix
 BINDER_SET_MAX_THREADS declaration

On Mon, Jun 03, 2013 at 02:44:25PM -0700, Arve Hjønnevåg wrote:
> On Mon, Jun 3, 2013 at 8:02 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> > On Fri, May 31, 2013 at 04:17:34PM -0700, Arve Hjønnevåg wrote:
> >> On Wed, May 22, 2013 at 3:12 AM, Serban Constantinescu
> >> <serban.constantinescu@....com> wrote:
> >> > This change will fix the BINDER_SET_MAX_THREADS ioctl to use __u32
> >> > instead of size_t for setting the max threads. Thus using the same
> >> > handler for 32 and 64bit kernels.
> >> >
> >> > This value is stored internally in struct binder_proc and set to 15
> >> > on open_binder() in the libbinder API(thus no need for a 64bit size_t
> >> > on 64bit platforms).
> >> >
> >> > The change does not affect existing 32bit ABI.
> >> >
> >> > Signed-off-by: Serban Constantinescu <serban.constantinescu@....com>
> >> > ---
> >> >  drivers/staging/android/binder.h |    2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
> >> > index 2f94d16..1761541 100644
> >> > --- a/drivers/staging/android/binder.h
> >> > +++ b/drivers/staging/android/binder.h
> >> > @@ -86,7 +86,7 @@ struct binder_version {
> >> >
> >> >  #define BINDER_WRITE_READ              _IOWR('b', 1, struct binder_write_read)
> >> >  #define        BINDER_SET_IDLE_TIMEOUT         _IOW('b', 3, __s64)
> >> > -#define        BINDER_SET_MAX_THREADS          _IOW('b', 5, size_t)
> >> > +#define        BINDER_SET_MAX_THREADS          _IOW('b', 5, __u32)
> >> >  #define        BINDER_SET_IDLE_PRIORITY        _IOW('b', 6, __s32)
> >> >  #define        BINDER_SET_CONTEXT_MGR          _IOW('b', 7, __s32)
> >> >  #define        BINDER_THREAD_EXIT              _IOW('b', 8, __s32)
> >> > --
> >> > 1.7.9.5
> >> >
> >>
> >> Acked-by: Arve Hjønnevåg <arve@...roid.com>
> >
> > What about patches 1 and 2 in this series?
> >
> 
> I apparently only responded privately to those. I just resent them.

Thanks for that.  I'll wait for the series to be fixed up and resent
before doing anything with them.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/