linux-kernel - RE: [PATCH] mfd: DT bindings for the palmas family MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DC88CAD03C0052499C1907B327FC63229E8AFE@DBDE04.ent.ti.com>
Date:	Tue, 4 Jun 2013 06:24:45 +0000
From:	"J, KEERTHY" <j-keerthy@...com>
To:	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee.jones@...aro.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"broonie@...nsource.wolfsonmicro.com" 
	<broonie@...nsource.wolfsonmicro.com>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"rob@...dley.net" <rob@...dley.net>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"wim@...ana.be" <wim@...ana.be>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
	"Kristo, Tero" <t-kristo@...com>, Ian Lartey <ian@...mlogic.co.uk>
Subject: RE: [PATCH] mfd: DT bindings for the palmas family MFD



> -----Original Message-----
> From: Stephen Warren [mailto:swarren@...dotorg.org]
> Sent: Tuesday, June 04, 2013 2:09 AM
> To: Lee Jones
> Cc: J, KEERTHY; linux-kernel@...r.kernel.org; linux-
> doc@...r.kernel.org; devicetree-discuss@...ts.ozlabs.org;
> broonie@...nsource.wolfsonmicro.com; rob.herring@...xeda.com;
> rob@...dley.net; mturquette@...aro.org; sameo@...ux.intel.com;
> wim@...ana.be; lgirdwood@...il.com; gg@...mlogic.co.uk; Kristo, Tero;
> Ian Lartey
> Subject: Re: [PATCH] mfd: DT bindings for the palmas family MFD
> 
> On 06/03/2013 08:18 AM, Lee Jones wrote:
> > On Mon, 03 Jun 2013, J Keerthy wrote:
> >> Add the various binding files for the palmas family of chips. There
> >> is a top level MFD binding then a seperate binding for regulators IP
> blocks on chips.
> 
> >> diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt
> >> b/Documentation/devicetree/bindings/mfd/palmas.txt
> 
> >> +Example:
> >> +
> >> +palmas {
> >
> > Should this be 'palmas@48 {', as it has an address?
> 
> It's common to only include the unit-address (@48) if it's needed to
> make the node name unique (i.e. if you had multiple palmas devices).

Yeah. We generally have one Palmas device.

> 
> >> diff --git
> >> a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
> >> b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
> 
> > See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> >
> >> +	       ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 -
> auto,
> >> +	       2 - eco, 3 - forced pwm
> >
> > I've seen lots of sleep-mode properties, can't we define a generic
> > one?
> 
> Isn't it HW-specific?

Yeah. Hence it is ti,sleep-mode.

Regards,
Keerthy