linux-kernel - Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51AE025C.9030401@semaphore.gr>
Date:	Tue, 04 Jun 2013 18:06:04 +0300
From:	Stratos Karafotis <stratosk@...aphore.gr>
To:	Viresh Kumar <viresh.kumar@...aro.org>
CC:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-pm@...r.kernel.org,
	cpufreq@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

On 06/04/2013 08:19 AM, Viresh Kumar wrote:
> On 4 June 2013 01:18, Stratos Karafotis <stratosk@...aphore.gr> wrote:
>> Calculation of frequency target in ondemand governor changed and it is
>
> s/frequency target/target frequency

I will change it also in 3/3 that I use the same.

>> independent from measured average frequency.
>>
>> Remove unused__cpufreq_driver_getavg function and getavg member from
>> cpufreq_driver struct. Also, remove the callback getavg in
>> acpi_cpufreq_driver.
>>
>> Signed-off-by: Stratos Karafotis <stratosk@...aphore.gr>
>> ---
>>   drivers/cpufreq/Makefile       |  2 +-
>>   drivers/cpufreq/acpi-cpufreq.c |  5 -----
>>   drivers/cpufreq/cpufreq.c      | 12 ------------
>>   include/linux/cpufreq.h        |  6 ------
>>   4 files changed, 1 insertion(+), 24 deletions(-)
>>
>> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
>> index 6ad0b91..aebd4ef 100644
>> --- a/drivers/cpufreq/Makefile
>> +++ b/drivers/cpufreq/Makefile
>> @@ -23,7 +23,7 @@ obj-$(CONFIG_GENERIC_CPUFREQ_CPU0)    += cpufreq-cpu0.o
>>   # powernow-k8 can load then. ACPI is preferred to all other hardware-specific drivers.
>>   # speedstep-* is preferred over p4-clockmod.
>>
>> -obj-$(CONFIG_X86_ACPI_CPUFREQ)         += acpi-cpufreq.o mperf.o
>
> Should this be done in 3/3 ?
>

acpi-cpufreq does not use mperf after 2/3. Why should we compile it with
CONFIG_X86_ACPI_CPUFREQ?
Do you want me to move the change in 3/3?

Thanks,
Stratos

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/