linux-kernel - Re: [PATCH 4/4] cw1200: hwio: Remove an unnecessary goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130604150910.GA13278@shaftnet.org>
Date:	Tue, 4 Jun 2013 11:09:10 -0400
From:	Solomon Peachy <pizza@...ftnet.org>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 4/4] cw1200: hwio: Remove an unnecessary goto

On Tue, Jun 04, 2013 at 07:44:50AM -0700, Joe Perches wrote:
> goto after return is wrong.
> 
> The other code in this block needs to set an
> error value then goto an error release block.
> 
> This one doesn't need to release anything and
> was likely a copy/paste remainder.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Acked-By: Solomon Peachy <pizza@...ftnet.org>

> ---
>  drivers/net/wireless/cw1200/hwio.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/cw1200/hwio.c b/drivers/net/wireless/cw1200/hwio.c
> index 142f45ef..dad3fb3 100644
> --- a/drivers/net/wireless/cw1200/hwio.c
> +++ b/drivers/net/wireless/cw1200/hwio.c
> @@ -178,7 +178,6 @@ int cw1200_indirect_read(struct cw1200_common *priv, u32 addr, void *buf,
>  	if ((buf_len / 2) >= 0x1000) {
>  		pr_err("Can't read more than 0xfff words.\n");
>  		return -EINVAL;
> -		goto out;
>  	}
>  
>  	priv->hwbus_ops->lock(priv->hwbus_priv);
> -- 
> 1.8.1.2.459.gbcd45b4.dirty
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Solomon Peachy        		       pizza at shaftnet dot org	 
Delray Beach, FL                          ^^ (email/xmpp) ^^
Quidquid latine dictum sit, altum viditur.

Content of type "application/pgp-signature" skipped