linux-kernel - Re: [PATCH, RFC 2/2] USB: host: make USB_ARCH_HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Jun 2013 12:58:30 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Arnd Bergmann <arnd@...db.de>
cc:	linux-usb@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH, RFC 2/2] USB: host: make USB_ARCH_HAS_?HCI obsolete

On Tue, 4 Jun 2013, Arnd Bergmann wrote:

> On Tuesday 04 June 2013 11:22:01 Alan Stern wrote:
> > 
> > Instead of doing this, it makes more sense to enable USB_ARCH_HAS_HCD
> > whenever host-side USB is enabled.  In other words,
> > 
> >         def_bool USB
> 
> The problem with this is that a lot of drivers (24 to be exact) are defined
> like
> 
> config INPUT_ATI_REMOTE2
>         tristate "ATI / Philips USB RF remote control"
>         depends on USB_ARCH_HAS_HCD
>         select USB

Oops.  That's a problem.

> so that would create a circular dependency unless we change all of them
> at once. I did that when creating this patch, but then decided to
> revert it for now and do smaller steps.

Okay.  Changing those 24 should be the next step.

> We could do
> 
> config USB_ARCH_HAS_HCD
> 	def_bool USB_SUPPORT
> 
> or
> 
> config USB_ARCH_HAS_HCD
> 	def_bool y
> 
> which would both have the exact same behavior as 'def_bool HAS_IOMEM'.

I'm in favor of "def_bool y".

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/