linux-kernel - Re: [PATCH 3/6] keucr: migrate printk to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130605093206.GQ28112@mwanda>
Date:	Wed, 5 Jun 2013 02:32:07 -0700 (PDT)
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Johannes Schilling <of82ecuq@....cs.fau.de>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Kurt Kanzenbach <shifty91@...il.com>,
	linux-kernel@...cs.fau.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Al Cho <acho@...ell.com>,
	Amarjargal Gundjalam <amarjargal16@...il.com>,
	Laura Lawniczak <laura.lawniczak@...glemail.com>
Subject: Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

On Wed, Jun 05, 2013 at 10:50:03AM +0200, Johannes Schilling wrote:
> diff --git a/drivers/staging/keucr/init.c b/drivers/staging/keucr/init.c
> index a0fdffd..0e8ced1 100644
> --- a/drivers/staging/keucr/init.c
> +++ b/drivers/staging/keucr/init.c
> @@ -19,13 +19,13 @@ int ENE_InitMedia(struct us_data *us)
>  	int	result;
>  	BYTE	MiscReg03 = 0;
>  
> -	printk(KERN_INFO "--- Init Media ---\n");
> +	dev_info("--- Init Media ---\n");

Come on people, what's going on here?  This won't compile at all. :/

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/