linux-kernel - Re: [PATCH 6/6] keucr: use more specific max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130605094517.GS28112@mwanda>
Date:	Wed, 5 Jun 2013 12:45:17 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Johannes Schilling <of82ecuq@....cs.fau.de>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Kurt Kanzenbach <shifty91@...il.com>,
	linux-kernel@...cs.fau.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Al Cho <acho@...ell.com>,
	Amarjargal Gundjalam <amarjargal16@...il.com>,
	Laura Lawniczak <laura.lawniczak@...glemail.com>
Subject: Re: [PATCH 6/6] keucr: use more specific max_t(int, ..

On Wed, Jun 05, 2013 at 10:50:06AM +0200, Johannes Schilling wrote:
> --- a/drivers/staging/keucr/transport.c
> +++ b/drivers/staging/keucr/transport.c
> @@ -708,8 +708,8 @@ int usb_stor_Bulk_transport(struct scsi_cmnd *srb, struct us_data *us)
>  
>  		} else {
>  			residue = min(residue, transfer_length);
> -			scsi_set_resid(srb, max(scsi_get_resid(srb),
> -							(int) residue));
> +			scsi_set_resid(srb, max_t(int, scsi_get_resid(srb),
> +							(int)residue));
                                                        ^^^^^
This cast isn't needed any more when you use max_t.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/