linux-kernel - Re: [PATCH v3] include/linux/skbuff.h: using '(_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51AF1DED.6050305@asianux.com>
Date:	Wed, 05 Jun 2013 19:15:57 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	David Miller <davem@...emloft.net>
CC:	David.Laight@...LAB.COM, andy.shevchenko@...il.com,
	edumazet@...gle.com, pshelar@...ira.com, mgorman@...e.de,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, bhutchings@...arflare.com
Subject: Re: [PATCH v3] include/linux/skbuff.h: using '(__u16) ~0U' instead
 of '~0U'

On 06/05/2013 04:36 PM, David Miller wrote:
> From: Chen Gang <gang.chen@...anux.com>
> Date: Wed, 05 Jun 2013 08:54:22 +0800
> 
>> > 
>> > Both 'transport_header' and 'mac_header' are __u16, which are
>> > never equal to '~0U'.
>> > 
>> > So need use '(__u16) ~0U' instead of '~0U'.
>> > 
>> > The related warning (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
>> >   include/linux/skbuff.h:1587:2: warning: comparison is always true due to limited range of data type [-Wtype-limits]
>> >   ...
>> > 
>> > Use meaningful macro instead of hard code number, and better to
>> > initialize 'skb->transport_header' in __alloc_skb_head(), too.
>> > 
>> > 
>> > 
>> > Signed-off-by: Chen Gang <gang.chen@...anux.com>
> Your patch doesn't apply to the tree because this has been fixed already
> for several days by using "typeof(x) ~0U"
> 
> 

OK, thanks.

-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/